Support .idl files for ROS message/service/action #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds full support for ROS2 .idl files by extending parsing, generation, testing, and documentation to include IDL-based interfaces.
- Extend
packages.jsand directory walkers to detect and store.idlfiles. - Integrate a Python-based IDL-to-ROS converter and wire it into
index.jsunder a new--idlflag. - Update tests, npm scripts, CI workflows, versioning, and README to cover IDL support.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/test-message-type.js | Clean up by destroying the subscription after message |
| test/test-message-generation-bin.js | Add --idl flag detection for binary-script tests |
| rosidl_gen/packages.js | Introduce idls bucket and branch logic for .idl |
| rosidl_gen/index.js | Add --idl flag, directory setup, and conversion logic |
| rosidl_gen/generator.json | Bump version to 1.0.0 and include .idl in description |
| package.json | Add generate-messages-idl and test-idl scripts |
| README.md | Document IDL-based message generation |
| .github/workflows/windows-build-and-test.yml | Update Windows runner version |
| .github/workflows/windows-build-and-test-compatibility.yml | Update Windows runner version |
| .github/workflows/linux-x64-build-and-test.yml | Add IDL test step for ROS rolling |
Comments suppressed due to low confidence (3)
.github/workflows/windows-build-and-test.yml:20
- The runner label 'windows-2025' is not a supported GitHub Actions image and will cause CI failures; consider using a valid label such as 'windows-2022'.
runs-on: windows-2025
.github/workflows/windows-build-and-test-compatibility.yml:9
- The runner label 'windows-2025' is invalid; update to a supported runner like 'windows-2022' to avoid CI errors.
runs-on: windows-2025
README.md:35
- The link anchor '#ros2-interface-message-generation-important' doesn’t match any heading (likely should be '#ros2-interface-message-generation'); update to the correct anchor to prevent a broken TOC link.
- [ROS2 Interface Message Generation](#ros2-interface-message-generation-important)
minggangw
added a commit
that referenced
this pull request
Jul 7, 2025
This PR adds full support for ROS2 `.idl` files by extending parsing, generation, testing, and documentation to include IDL-based interfaces. - Extend `packages.js` and directory walkers to detect and store `.idl` files. - Integrate a Python-based IDL-to-ROS converter and wire it into `index.js` under a new `--idl` flag. - Update tests, npm scripts, CI workflows, versioning, and README to cover IDL support. - Pump `rosidl-generator` to `1.0.0`. Meanwhile, this patch pumps Windows action image to `windows-2025` because the previous one has been deprecated. Fix: #764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full support for ROS2
.idlfiles by extending parsing, generation, testing, and documentation to include IDL-based interfaces.packages.jsand directory walkers to detect and store.idlfiles.index.jsunder a new--idlflag.rosidl-generatorto1.0.0.Meanwhile, this patch pumps Windows action image to
windows-2025because the previous one has been deprecated.Fix: #764